Add building and container recipes#24
Closed
rico-haas wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Closed
Add building and container recipes#24rico-haas wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
rico-haas wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Conversation
Author
|
I can't add myself as an Assignee :( |
MakisH
reviewed
Apr 11, 2026
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Everything looks good here and works, thanks!
| @@ -0,0 +1,19 @@ | |||
| cmake_minimum_required(VERSION 3.28) | |||
There was a problem hiding this comment.
I would not add the latest version as minimum required if there is no special reason: this might cause issues in older systems.
| cmake -DYAML_BUILD_SHARED_LIBS=ON .. && make && make install && \ | ||
| cd ../../.. && rm -rf yaml-cpp | ||
|
|
||
| WORKDIR /mnt/host/ |
There was a problem hiding this comment.
If there is a WORKDIR defined, I would expect it to exist independently of the user-defined mount (e.g., with files copied).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gitlab username: haasro
Run these commands in the root directory to test the exercise submission:
Then, inside the container: