Skip to content

submission#19

Closed
B3tah3 wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
B3tah3:main
Closed

submission#19
B3tah3 wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
B3tah3:main

Conversation

@B3tah3
Copy link
Copy Markdown

@B3tah3 B3tah3 commented Nov 25, 2025

didnt get many libraries to run, but the build system in the docker container should work.

Copy link
Copy Markdown

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the submission was early and there was time to improve it, it looks like this submission is incomplete. There are several issues, with the most important being that there is no content in the CMakeLists.txt, and no use of it in the Dockerfile.

Comment thread CMakeLists.txt
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no content in the CMakeLists.txt, which was the main focus of the exercise.

Comment thread Dockerfile

COPY main.cpp ./

RUN apt-get update && apt-get install -y gcc g++
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies (Boost, deal.II) are not installed.

Comment thread Dockerfile
COPY main.cpp ./

RUN apt-get update && apt-get install -y gcc g++
RUN g++ main.cpp -o main
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using cmake and make, but directly the compiler.

Comment thread Dockerfile
FROM ubuntu:24.04
WORKDIR /usr/local/app

COPY main.cpp ./
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main.cpp also depends on flatset/flatset.hpp, which is not copied into the container. The image fails to build with:

 => ERROR [5/5] RUN g++ main.cpp -o main                                                                                                                                            0.2s 
------                                                                                                                                                                                   
 > [5/5] RUN g++ main.cpp -o main:                                                                                                                                                       
0.147 main.cpp:2:10: fatal error: flatset/flatset.hpp: No such file or directory                                                                                                         
0.147     2 | #include "flatset/flatset.hpp"                                                                                                                                             
0.147       |          ^~~~~~~~~~~~~~~~~~~~~                                                                                                                                             
0.147 compilation terminated.

@MakisH MakisH closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants