Fix ZIP downloads for external uploads directories - #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ZIP URL resolution when WordPress stores uploads outside or symlinked away from
WP_CONTENT_DIRby using the authoritativewp_upload_dir()filesystem-to-URL mapping.Validate completed archives before reporting success and return actionable errors for missing, unreadable, or publicly inaccessible ZIP files.
Add regression tests for external uploads mappings and false-success prevention.
Tests:
vendor/bin/phpunit(356 tests, 4,531 assertions), plus a successful WordPress 7.0.2/PHP 8.4 Playground export.