[SL-UP] Updated GetMotionLockStatus Logic - #935
Draft
Arghya Dutta (silabs-ArghyaD) wants to merge 2 commits into
Draft
[SL-UP] Updated GetMotionLockStatus Logic#935Arghya Dutta (silabs-ArghyaD) wants to merge 2 commits into
Arghya Dutta (silabs-ArghyaD) wants to merge 2 commits into
Conversation
Arghya Dutta (silabs-ArghyaD)
marked this pull request as draft
May 3, 2026 14:57
arun-silabs
approved these changes
May 4, 2026
Rohan Sahay (rosahay-silabs)
requested changes
May 4, 2026
Rohan Sahay (rosahay-silabs)
left a comment
Contributor
There was a problem hiding this comment.
LGTM but SL-UP to main should be on CSA
Contributor
Author
This PR is just for internal review. I'll raise a separate CSA PR for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is only created for internal review
The current logic for GetMotionLockStatus first checks the kOperational in ConfigStatus first and then checks the Mode. Following the Matter Specs -
We're making sure that the ModeSet internally calls the ConfigStatusSet
So it's not necessary to check the kOperational in ConfigStatus first in GetMotionLockStatus.
Related issues
N/A
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines