Skip to content

[SL-UP] Updated GetMotionLockStatus Logic - #935

Draft
Arghya Dutta (silabs-ArghyaD) wants to merge 2 commits into
SiliconLabsSoftware:mainfrom
silabs-ArghyaD:fix/motion_lock_status_logic
Draft

[SL-UP] Updated GetMotionLockStatus Logic#935
Arghya Dutta (silabs-ArghyaD) wants to merge 2 commits into
SiliconLabsSoftware:mainfrom
silabs-ArghyaD:fix/motion_lock_status_logic

Conversation

@silabs-ArghyaD

@silabs-ArghyaD Arghya Dutta (silabs-ArghyaD) commented May 3, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR is only created for internal review
The current logic for GetMotionLockStatus first checks the kOperational in ConfigStatus first and then checks the Mode. Following the Matter Specs -

While in maintenance mode, all commands (e.g: UpOrOpen, DownOrClose, GoTos) or local inputs that can result in movement, must be ignored and respond with a BUSY status. Additionally, the Operational bit of the ConfigStatus attribute should be set to its not operational value.

We're making sure that the ModeSet internally calls the ConfigStatusSet

    if (oldMode != newMode)
        Attributes::Mode::Set(endpoint, newMode);

    if (oldStatus != newStatus)
        ConfigStatusSet(endpoint, newStatus);

So it's not necessary to check the kOperational in ConfigStatus first in GetMotionLockStatus.

Related issues

N/A

Testing

  • Tested locally with CSA test scripts. The test cases were passing.

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

  • PR title is
    descriptive
  • Apply the
    “When in Rome…”
    rule (coding style)
  • PR size is short
  • Try to avoid "squashing" and "force-update" in commit history
  • CI time didn't increase

See: Pull Request Guidelines

@silabs-ArghyaD
Arghya Dutta (silabs-ArghyaD) requested a review from a team as a code owner May 3, 2026 14:56
@silabs-ArghyaD
Arghya Dutta (silabs-ArghyaD) marked this pull request as draft May 3, 2026 14:57

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but SL-UP to main should be on CSA

@silabs-ArghyaD

Copy link
Copy Markdown
Contributor Author

LGTM but SL-UP to main should be on CSA

This PR is just for internal review. I'll raise a separate CSA PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants