[MATTER-6390] WoM components changes - #997
[MATTER-6390] WoM components changes#997Jean-Francois Penven (jepenven-silabs) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Silicon Labs Matter component definitions to better fit Wake-On-Matter as an NCP-style application by making the BaseApplication layer optional, and introduces a new component intended to provide subscription tracking support.
Changes:
- Add
matter_custom_apptaskto excludeBaseApplication.*(and related headers) from MG platform builds when desired. - Move/adjust OTA header inclusion so
OTAConfig.his provided via the OTA support component. - Add a new
matter_subscription_managercomponent definition for subscription management sources/headers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| slc/component/matter-platform/ota/matter_ota_support.slcc | Adds an include entry to provide OTAConfig.h from the Silabs examples path. |
| slc/component/matter-platform/matter_platform_mg.slcc | Makes BaseApplication headers/sources conditional via unless: [matter_custom_apptask] and removes some includes. |
| slc/component/matter-platform/matter_custom_apptask.slcc | Introduces a new component to enable building without BaseApplication. |
| slc/component/matter-core-sdk/subsbcription_manager.slcc | Adds a new component definition intended to supply subscription manager header/source. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| quality: production | ||
| metadata: | ||
| sbom: | ||
| license: Zlib |
There was a problem hiding this comment.
Not an expert on licensing and mostly out of curiosity, but SL_MATTER_CUSTOM_APPTASK seems to be used in examples/platform/silabs/MatterConfig.cpp which is Apache 2.0. From my understanding Apache 2.0 isn't copyleft, so it is ok, but curious of the Zlib choice.
There was a problem hiding this comment.
Maybe Narendra knows more on this,
last when I worked on the SBOM ( licensing ) stuff, I remember we decided we do not need license if the component it selft is not referencing to a source file directly. we can remove it from here.
| quality: production | ||
| metadata: | ||
| sbom: | ||
| license: Zlib |
There was a problem hiding this comment.
Maybe Narendra knows more on this,
last when I worked on the SBOM ( licensing ) stuff, I remember we decided we do not need license if the component it selft is not referencing to a source file directly. we can remove it from here.
Issue Link:
#MATTER-6390
Description of Problem/Feature:
Wake-On-Matter is closer to a NCP application than a actual SoC application. As such it doesn't requires the BaseApplication layer nor the CRTP templates as the client is not expected to modified it to great lengths.
Description of Fix/Solution:
Added a component called
matter_custom_apptaskto build without the BaseApplication.cpp file.Also did a bit of cleanup in the
matter_platform_mg.slccfile.Added the subscription manager which handles the actives subscriptions present on the devices.
Testing Done:
Tested locally with a MG24