feat: dropdown menu component#99
Merged
SagarRajput-7 merged 3 commits intomainfrom Feb 2, 2026
Merged
Conversation
fee62e8 to
8e8a931
Compare
Contributor
|
@SagarRajput-7 we have a combobox component that works as a dropdown , apart from nested feature we have all of it in combobox, do we need this ? |
Contributor
@ishan621 they are similar is many sorts but they serves different task, combox is more of a select component while the dropdown is action menu, navigating etc. Additionally the Shadcn follows the same they have a dropdown menu component also, from which this particular is derived from. |
ishan621
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close https://github.com/SigNoz/engineering-pod/issues/3126
Storybook demo - https://67150c0b65fc0b0f718b1a58-fnewnzthbx.chromatic.com/