Psse parser consolidation - #201
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates PSS/e (PSSE) parsing paths to rely on PowerFlowFileParser.PowerModelsData and removes the legacy PowerFlowData-based parser integration, simplifying the parsing surface in PowerSystemCaseBuilder.
Changes:
- Switch the “PSSE 30 Test System” catalog entry to use
build_pti(PowerModels-based) and a new v30 RAW fixture. - Remove the
PowerFlowDatadependency and the now-unusedpowerflowdata_data.jlparser include. - Remove the specialized
build_pti_30helper and bump the package version to2.4.0.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/system_descriptor_data.jl |
Updates PSSE v30 test system descriptor to use the consolidated build_pti path. |
src/PowerSystemCaseBuilder.jl |
Drops PowerFlowData import and removes the include for the deleted parser file. |
src/parsers/powerflowdata_data.jl |
Deletes the legacy PowerFlowDataNetwork-based system construction code. |
src/library/pssetest_library.jl |
Removes build_pti_30 (legacy v30 path). |
Project.toml |
Removes PowerFlowData dependency/compat entry and bumps version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name = "PSSE 30 Test System", | ||
| description = "PSSE 30 Test system", | ||
| category = PSSEParsingTestSystems, | ||
| raw_data = joinpath(DATA_DIR, "psse_raw", "synthetic_data_v30.raw"), | ||
| build_function = build_pti_30, | ||
| raw_data = joinpath(DATA_DIR, "psse_raw", "11BUS_KUNDUR_30.raw"), | ||
| build_function = build_pti, |
There was a problem hiding this comment.
Usually I'd have Marck look at parser stuff, but this is small and simple enough that I feel ok approving it. I guess my one question: where does the functionality that used to live in src/parsers/powerflowdata_data.jl [deleted in this PR] land now?
edit: ofc fix the formatting first
The functionality for parsing legacy PSSE files (which was the original point of this parsing path) is now covered in the PowerModelsData path: Sienna-Platform/PowerFlowFileParser.jl#20 |
|
This needs #206 to pass CI tests |
Ok I changed the target branch of that PR to this one. If you're good with those changes, you can hit merge on that (and then CI here should pass) |
…e-system-call Fix/remove set units base system call
|
Running the tests locally with the most recent version of |
Requires Sienna-Platform/PowerFlowFileParser.jl#21