Skip to content

Psse parser consolidation - #201

Merged
m-bossart merged 7 commits into
mb/transformer-refactorfrom
psse-parser-consolidation
Jul 23, 2026
Merged

Psse parser consolidation#201
m-bossart merged 7 commits into
mb/transformer-refactorfrom
psse-parser-consolidation

Conversation

@m-bossart

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates PSS/e (PSSE) parsing paths to rely on PowerFlowFileParser.PowerModelsData and removes the legacy PowerFlowData-based parser integration, simplifying the parsing surface in PowerSystemCaseBuilder.

Changes:

  • Switch the “PSSE 30 Test System” catalog entry to use build_pti (PowerModels-based) and a new v30 RAW fixture.
  • Remove the PowerFlowData dependency and the now-unused powerflowdata_data.jl parser include.
  • Remove the specialized build_pti_30 helper and bump the package version to 2.4.0.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/system_descriptor_data.jl Updates PSSE v30 test system descriptor to use the consolidated build_pti path.
src/PowerSystemCaseBuilder.jl Drops PowerFlowData import and removes the include for the deleted parser file.
src/parsers/powerflowdata_data.jl Deletes the legacy PowerFlowDataNetwork-based system construction code.
src/library/pssetest_library.jl Removes build_pti_30 (legacy v30 path).
Project.toml Removes PowerFlowData dependency/compat entry and bumps version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1630 to +1634
name = "PSSE 30 Test System",
description = "PSSE 30 Test system",
category = PSSEParsingTestSystems,
raw_data = joinpath(DATA_DIR, "psse_raw", "synthetic_data_v30.raw"),
build_function = build_pti_30,
raw_data = joinpath(DATA_DIR, "psse_raw", "11BUS_KUNDUR_30.raw"),
build_function = build_pti,
@m-bossart
m-bossart requested a review from luke-kiernan July 21, 2026 15:09
@luke-kiernan
luke-kiernan requested a review from mcllerena July 21, 2026 18:29

@luke-kiernan luke-kiernan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I'd have Marck look at parser stuff, but this is small and simple enough that I feel ok approving it. I guess my one question: where does the functionality that used to live in src/parsers/powerflowdata_data.jl [deleted in this PR] land now?

edit: ofc fix the formatting first

@m-bossart

Copy link
Copy Markdown
Contributor Author

Usually I'd have Marck look at parser stuff, but this is small and simple enough that I feel ok approving it. I guess my one question: where does the functionality that used to live in src/parsers/powerflowdata_data.jl [deleted in this PR] land now?

edit: ofc fix the formatting first

The functionality for parsing legacy PSSE files (which was the original point of this parsing path) is now covered in the PowerModelsData path: Sienna-Platform/PowerFlowFileParser.jl#20

@m-bossart

Copy link
Copy Markdown
Contributor Author

This needs #206 to pass CI tests

@luke-kiernan

Copy link
Copy Markdown
Collaborator

This needs #206 to pass CI tests

Ok I changed the target branch of that PR to this one. If you're good with those changes, you can hit merge on that (and then CI here should pass)

…e-system-call

Fix/remove set units base system call
@luke-kiernan

Copy link
Copy Markdown
Collaborator

Running the tests locally with the most recent version of PowerSystemsTestData (psy6 branch): the tests pass, but there's still 1 error-level log that causes the "no errors in tests" to fail. The same error is visible in the CI logs: search for "topologically isolated bus 16"

@m-bossart
m-bossart changed the base branch from psy6 to mb/transformer-refactor July 23, 2026 15:42
@m-bossart
m-bossart merged commit 8f31c30 into mb/transformer-refactor Jul 23, 2026
1 of 7 checks passed
@m-bossart
m-bossart deleted the psse-parser-consolidation branch July 23, 2026 16:01
@luke-kiernan
luke-kiernan restored the psse-parser-consolidation branch July 24, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants