transformer-refactor - #200
Merged
Merged
Conversation
…-call' into mb/transformer-refactor
…-area transfer areas PowerFlowFileParser removed PowerFlowDataNetwork and its parse path (commit fc3eb70) without a PSB companion change, leaving PowerSystemCaseBuilder unable to precompile (UndefVarError: PowerFlowDataNetwork not defined). Delete the dormant src/parsers/powerflowdata_data.jl maker and its include/import, and convert build_pti_30 to the standard PowerModelsData path used by its sibling build_pti. Routing v30 files through the full parser surfaces two previously-dormant referential-integrity crashes in power_models_data.jl (the legacy maker never exercised these code paths for v30 data): an inter-area-transfer record naming an undefined area throws inside read_bus! (non-nullable AreaInterchange fields), and a VSC-line record naming undefined buses throws a raw KeyError in read_vscline!. Both now warn and skip the offending record instead of crashing, matching the existing skip-with-warning convention used elsewhere in this file. The v30 test fixture also carries a three-winding transformer with an implausible tertiary tap (WINDV3 = 13.8 pu, outside PSY's valid range) that the legacy path never validated. build_pti_30 now builds with runchecks = false, following the existing build_psse_modified_14bus_sys precedent for fixtures with known-bad data outside a builder's format-parsing purpose. Updated the "PSSE 30 Test System" pinning testset to assert the new tolerant behavior (both warnings, no AreaInterchange, no VSC line, one ThreeWindingTransformer) instead of the old PowerFlowData-path warning strings. Dropped the now-unused PowerFlowData dependency.
…e-system-call Fix/remove set units base system call
Psse parser consolidation
jd-lara
self-requested a review
July 24, 2026 01:26
jd-lara
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accompanying PRs:
Sienna-Platform/PowerSystemsTestData#121
Sienna-Platform/PowerFlowFileParser.jl#19