Fix binlog file lexographical comparison #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correctly order files like binlog.999999 < binlog.1000000. Would cause the stream to ignore all incoming events and render the gh-ost process stuck: https://github.com/github/gh-ost/blob/48b34bcbfde730b2548d598dee98e9c1f0d2fcce/go/binlog/gomysql_reader.go#L85-L88 Possibly remediated by 005043d too, which drops the SmallerThanOrEqual check from GoMySqlReader.handleRowsEvent
coding-chimp
approved these changes
Nov 6, 2025
| return this.LogFile == coord.LogFile && this.LogPos == coord.LogPos // No Type comparison | ||
| } | ||
|
|
||
| // FileSmallerThan returns true if this coordinate's file is strictly smaller than the other's. |
There was a problem hiding this comment.
Was this not used anymore? Looks like the same comment still exists in a different/wrong place.
Member
Author
There was a problem hiding this comment.
Yup, FileSmallerThan as well as FileNumberDistance were both unused. The latter I used here, too bad I didn't catch the comment before the PR got merge, I'll open another one! #quality
Member
Author
There was a problem hiding this comment.
There's more unused stuff there, I'll change the PR base once the build is green. #20
Member
Author
|
In favour of #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal counterpart to github#1604
Migration got stuck unable to cutover, treating all incoming events as old events in GoMySqlReader.
48b34bc is the current version, though the PR is opened against newly synced master that introduced
FileBinlogCoordinates.