Draft
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
gonzaloriestra
force-pushed
the
eslint-9-configuration
branch
from
04fcf60 to
e954f9b
Compare
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3718 tests passing in 1438 suites. Report generated by 🧪jest coverage report action from e954f9b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
ESLint 8 has reached end of life and the ecosystem has moved to ESLint 9 with its new "flat config" format. More info here: https://eslint.org/docs/latest/use/migrate-to-9.0.0
This migration is necessary to:
.eslintrc.*configuration@typescript-eslintv8 which includes improved type checking and drops deprecated rules likeban-typesWHAT is this pull request doing?
This PR is focused on the configuration changes, what's important to review. And the next one fixes all the broken lint issues.
Configuration Migration:
.eslintrc.cjstoeslint.config.js(flat config format).eslintignore(ignores are now defined inline in the config)@shopify/eslint-plugin-clito export flat configPlugin Updates:
eslint: 8.x → 9.x@typescript-eslint/*: 7.x → 8.x@shopify/eslint-plugin: → 50.0.0 (flat config compatible)eslint-plugin-import→eslint-plugin-import-x(ESM compatible replacement)eslint-plugin-node→eslint-plugin-n(maintained fork,node/→n/prefix)eslint-plugin-vitest→@vitest/eslint-pluginHow to test your changes?
CI
Measuring impact
How do we know this change was effective? Please choose one:
Checklist