-
Notifications
You must be signed in to change notification settings - Fork 2
Adopt AI Policy #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt AI Policy #27
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| name: Update shared configs | ||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: 0 6 1 * * | ||
| jobs: | ||
| sync: | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| uses: ShipSoft/.github/.github/workflows/config-sync.yml@main | ||
| with: | ||
| base: main | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # AI Policy | ||
|
|
||
| AI-assisted contributions are welcome. We ask that you: | ||
|
|
||
| - Disclose that AI was used and name the tool/model. | ||
| - Review and understand every line you submit; you are responsible for it. | ||
| - Meet the same quality, testing, and style standards as any contribution. | ||
| - Not use fully autonomous agents to open issues or PRs. | ||
|
Comment on lines
+3
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Use normative language for mandatory requirements. Line 3 introduces the rules as a request, and Line 17 says the commit trailer “can be used.” The PR objective describes these as requirements. State mandatory actions with Proposed wording-AI-assisted contributions are welcome. We ask that you:
+AI-assisted contributions are welcome. Contributors must:
-The Linux kernel trailer can be used to credit AI assistance, like this:
+AI-assisted commits must include an `Assisted-by` trailer to credit AI assistance:Also applies to: 16-22 🤖 Prompt for AI Agents |
||
| - Respond to reviewers yourself. | ||
| - Clearly mark AI text in descriptions and issues. | ||
|
|
||
| This applies to issues and comments as well as pull requests. Using AI for | ||
| translation or grammar help is fine. Contributions that ignore this policy may | ||
| be closed. | ||
|
Comment on lines
+5
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Define the disclosure scope and exception. Line 10 does not mention comments, although Line 12 includes comments in scope. The policy also does not define the required marker. Line 13 does not state whether translation and grammar assistance is exempt from the disclosure and labeling rules. Specify the exact surfaces, label format, and exception rule. 🤖 Prompt for AI Agents |
||
|
|
||
| Only humans can be named as co-authors, and AI can _never_ sign off on a | ||
| commit. The Linux kernel trailer can be used to credit AI assistance, like | ||
| this: | ||
|
|
||
| ```text | ||
| Assisted-by: <harness>:<model> | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: ShipSoft/data-model
Length of output: 1526
🌐 Web query:
GitHub Actions reusable workflows pin commit SHA safest reference official documentation💡 Result:
Using a full-length commit SHA is the officially recommended and safest method for referencing reusable workflows in GitHub Actions [1][2]. This practice provides stability and security by ensuring that the workflow remains immutable, effectively mitigating the risk of malicious code injection or unexpected changes that could occur if you rely on mutable references like branch names or tags [2][3][4]. Official documentation and security guidance emphasize the following points: 1. Immutable References: When you reference a reusable workflow using {owner}/{repo}/{path}@{ref}, the {ref} can be a SHA, a release tag, or a branch name [1]. Using a full-length (40-character) commit SHA ensures that your workflow always executes the exact same code, regardless of any future changes or force-pushes to the referenced repository [2][3][4]. 2. Security Mitigation: Pinning to a commit SHA is critical for security because it prevents attackers from compromising a workflow by updating a tag or branch they control [2][4]. Because reusable workflows run within the caller's security context and can inherit secrets, an unpinned reference introduces a significant supply chain risk [5]. 3. Organizational Enforcement: GitHub supports organizational policies to enforce SHA pinning [2][4]. Administrators can configure policies to require that all actions and reusable workflows be pinned to a full-length commit SHA, causing any workflow that uses an unpinned reference to fail [2][4]. 4. Best Practice for Visibility: Even when pinning to a SHA, it is a common best practice to include the human-readable version tag as a comment in your YAML file (e.g., uses: owner/repo/.github/workflows/workflow.yml@sha1234567... # v1.2.3) to maintain clarity on which version is being used [6]. For reusable workflows located within the same repository, you do not need to use an @{ref} suffix, as they automatically reference the same commit as the caller workflow [1]. However, for all third-party or cross-repository workflows, explicit SHA pinning is the standard security requirement [2][5].
Citations:
Pin the reusable workflow to a full commit SHA.
@mainis mutable and can change the code executed by this repository without a local change. Pinconfig-sync.ymlto a reviewed 40-character commit SHA. Add an update process if automatic shared-workflow updates are required.🤖 Prompt for AI Agents
Source: MCP tools