feat(g4): identify hit placements with SimHit::geometryNodeId - #97
feat(g4): identify hit placements with SimHit::geometryNodeId#97matclim wants to merge 1 commit into
Conversation
Physics Metrics ComparisonAll configurations match reference (no significant differences)
About this comparisonPhysics metrics are extracted from ROOT files and compared. Metrics stored in git notes: |
|
Warning Review limit reached
Next review available in: 111 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| // Stable identifier for one placement — a node of the touchable history. | ||
| // detectorId only names the subsystem, and a single logical volume can be | ||
| // placed thousands of times (9600 copies of /SHiP/trackers/straw_gas share one | ||
| // G4LogicalVolume), so the copy numbers along the touchable path are what | ||
| // distinguish one straw from another. FNV-1a over (copy number, volume) at | ||
| // every depth, folded to 31 bits because SimHit::geometryNodeId is int32 and a | ||
| // negative id would read as a sentinel. | ||
| // | ||
| // Stable within a run but not across geometry changes, and being a hash it can | ||
| // in principle collide: it identifies a node, it does not encode a position in | ||
| // the hierarchy. Never persist it as a channel number. |
There was a problem hiding this comment.
Don't we want to persist the geometry_node_id for MC?
From the discussion in ShipSoft/data-model#20, I think we agreed that for MC truth, geoemtry node ideas are the only sensible thing, as channel numbers are only available after digitisation.
Also, we should not implement our own hash function here.
2 participants
Checklist
pixi run lint)Stack created with GitHub Stacks CLI • Give Feedback 💬