fix(geometry): use the real GeoModel sensitive volumes, and fail on unmatched patterns - #101
fix(geometry): use the real GeoModel sensitive volumes, and fail on unmatched patterns#101matclim wants to merge 1 commit into
Conversation
…nmatched patterns
Physics Metrics ComparisonAll configurations match reference (no significant differences)
About this comparisonPhysics metrics are extracted from ROOT files and compared. Metrics stored in git notes: |
|
Warning Review limit reached
Next review available in: 112 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
olantwin
left a comment
olantwin
left a comment
There was a problem hiding this comment.
It might be possible to do this more elegantly (also the initial matching), but fine for now.
Please drop the matplotlib change, I don't want it as dependency of aegir.
| cpp: 'geometry_geomodel_provider', | ||
| db_file: 'ship_geometry.db', | ||
| sensitive_volumes: ['ScoringPlane'], | ||
| // Index in this list becomes SimHit::detectorId, so order matters and |
There was a problem hiding this comment.
Not sure this is the best way to do it. Ideally we would be using the enum from data-model
3 participants
No description provided.