content: kit codes on every kit list, model covers on every surface, and a reset screen that says nothing - #254
Merged
carlosvirreira merged 1 commit intoAug 24, 2026
Conversation
…and a reset screen that says nothing - asset-identifiers-qr-id-sam-id-property-id.mdx: the "Where chips appear" list was missing five kit surfaces that shelf.nu #2903 filled in, and the article never said SAM IDs are asset-only. A workspace preferring SAM ID sees a QR fallback on every kit row, and the tooltip now names that as a product boundary rather than telling the reader to add one. - glossary/asset-models.mdx and updates/one-cover-image-for-a-whole-asset-model.mdx: both promised the model cover image "shows everywhere the asset does" since 2026-08-12. Seven surfaces did not, until shelf.nu #2914. The surfaces are now named individually, along with the one place it still does not reach. - how-to-reset-your-password-in-shelf.mdx: shelf.nu #2916 makes the forgot password screen answer every address identically. Explains why, and the two reasons a code never arrives. - features/calendar.mdx: shelf.nu #2871 makes an overdue booking red on the calendar, matching every other surface. The colour list also named "available", which is not a booking status. - scripts/media-pipeline/articles/kit-code-chips.mjs: read-only capture that asserts every kit row carries a code before shooting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preview deployment |
Contributor
Author
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by
Content changes
Factual corrections
content/glossary/asset-models.mdxandcontent/updates/one-cover-image-for-a-whole-asset-model.mdx— both pages have been over-claiming since 2026-08-12. Each said the model cover image "shows everywhere the asset does", and named booking and kit lists. #2914's sweep found seven surfaces where an inheriting asset rendered the placeholder instead: the booking overview, the home dashboard's newest assets, both scan pages, the QR and barcode scanned-item endpoints, and Quick find. That is now true, so the vague claim is replaced with the surfaces named one by one, plus the one place it still does not reach (an asset list embedded in a note, whose payload carries no model data).content/knowledge-base/asset-identifiers-qr-id-sam-id-property-id.mdx— the "Where chips appear" list named/kitsand the kit detail asset list and stopped there. Five further kit surfaces now render the chip. The whole list was reconciled against theAssetCodeBadgecall sites rather than only the delta, so a location's Assets tab, the booking assets sidebar and the kit group header are named too.content/features/calendar.mdx— the colour list read "reserved, checked out, available, or overdue". Available is not a booking status. Replaced with the five real ones and their colours, read from the switch inapp/utils/calendar.ts: Reserved blue, Ongoing purple, Overdue red, Complete green, Draft/Cancelled/Archived grey. #2871 is what makes Overdue red rather than amber.Content enhancements
content/knowledge-base/asset-identifiers-qr-id-sam-id-property-id.mdx— new "Kits do not have a SAM ID" section. The article offered SAM ID as a workspace-wide setting without ever saying it is asset-only, so a workspace that picks it sees a QR fallback on every kit row with no explanation. #2903 rewrote that tooltip for the same reason: it used to say "Add one (or change the workspace setting) to fix", which is an instruction nobody can follow, becauseKithas nosequentialIdcolumn and no UI to set one. The section says what the reader should actually do (prefer QR Code ID if you want kits and assets to read alike) and notes that the per-asset override has the same boundary.content/knowledge-base/how-to-reset-your-password-in-shelf.mdx— new section on why the screen looks identical whether or not a code was sent, and the two reasons one never arrives (no account on that address; the account signs in through SSO and has no Shelf password). Before #2916 the page answered three different ways and told an attacker which addresses were registered and which were federated.New content
content/updates/kit-codes-on-every-kit-list.mdx— changelog entry for #2903, covering the five surfaces and the tooltip correction.Review notes
Read from source, not from PR bodies. #2916's description says the domain-level "use SSO instead" answer was kept. The merged
forgot-password.tsxhas nocheckDomainSSOStatuscall at all, and no static SSO copy in the form either — its comment says such a hint "belongs in the page as static copy", which is a description of what someone could add, not of what shipped. The KB is written against the shipped file: every address gets the same "we've sent a 6-digit code" screen, and the SSO case is something the reader has to be told here because the app does not tell them. If a static hint later lands on that page, this section should be trimmed.Screenshot. One new image,
kit-code-chip-location.webp, captured live and inspected before committing.kit-code-chips.mjsasserts that every kit row on the Kits tab carries a code before it shoots, so a loader regression throws instead of publishing a caption the image does not support. Not registered inrun.mjs: three article scripts on the open #244 branch are unregistered for the same reason, and adding an entry on main would breakrun.mjs allon a missing file. Run it directly withnode scripts/media-pipeline/articles/kit-code-chips.mjs.No changelog entry for #2914, deliberately. The capability was announced on 2026-08-12 in
one-cover-image-for-a-whole-asset-model.mdx, naming surfaces that did not work. A second entry would be announcing our own bug rather than a change. Correcting the original entry so/updatesis true seemed the honest move instead. Say the word if you would rather have the entry, since a customer reported this one.No changelog entry for #2916 or #2871. #2916 is a security hardening whose only user-visible effect is a screen that reveals less, and #2871 is a colour that was wrong on one surface. Both are below the bar; the KB and the feature page carry them.
Impact scope
/features/calendarand/glossary/asset-models, both of which were making claims the product did not fully supportGenerated by Shelf Content Intelligence — PR→Website Sync