content: a kit's new members reach only that kit's bookings

[carlosvirreira]

Triggered by

• shelf.nu PR #2848: fix(kits): scope new-member booking propagation to bookings holding the kit — View PR

Product change summary

Adding an asset to a kit propagates that asset into the bookings the kit is already part of. The booking list was derived from the first kit member that had any booking row at all, with no filter on which kit that row belonged to. A QUANTITY_TRACKED asset can belong to several kits, so that member's rows could belong to a different kit's booking. The new member was then written into a booking that never held this kit, and bookings that genuinely did hold it were skipped. A customer reported the visible half: kits appearing in bookings she never added them to, extra items inside them, and bookings that refused to reserve because the stray asset created a conflict, with the reason only visible on hovering the disabled Reserve button.

Content changes

Content enhancements

• content/knowledge-base/kits.mdx — the Changing Kit Contents and Existing Bookings section only ever covered removing a member. It now has an Adding a member subsection covering the propagation, its booking-status scope, the kit-quantity inheritance for a quantity-tracked member, and the shared-asset case the bug came from. The existing removal content is unchanged and now sits under a Removing a member heading. updated bumped to 2026-08-14.

New content

• content/updates/kit-members-reach-only-their-own-bookings.mdx — changelog entry. Customer-reported, visible in existing data, and the entry names the remediation for anyone already affected.

Verified against the code, not the PR description

• Booking-status scope: updateKitAssets in apps/webapp/app/modules/kit/service.server.ts on main filters kitBookings to DRAFT | RESERVED | ONGOING | OVERDUE. The article names those four and says completed/archived/cancelled are untouched.
• Kit-quantity inheritance: the propagated BookingAsset rows take quantity from the new AssetKit slice rather than defaulting to 1, which is why the article says "at the kit's own quantity for a quantity-tracked member".
• Scoping: thisKitAssetKitIds is built from this kit's own AssetKit ids and the rows are deduped by booking, so "every such booking is updated rather than just the first one found" is literal.

Review notes

• The propagation now records a BOOKING_ASSETS_ADDED activity event, and the article deliberately does not mention it. It is an ActivityEvent row for reporting, not a BookingNote, so it does not appear in the booking's Activity tab, which is what a reader would assume from "activity". The PR is explicit that no note is written on purpose, and that the event has no report consumer yet. Documenting it would promise a user-visible trail that does not exist. content/knowledge-base/activity-logs-for-bookings.mdx was read and left alone for the same reason.
• The last paragraph of the update entry states plainly that existing stray rows are not cleaned up by the fix and that removing them from the booking clears the conflict. The app PR lists cleaning the reporter's rows as a separate follow-up, so this is the honest position rather than an implied automatic repair.
• No screenshot. Reproducing this needs a quantity-tracked asset in two kits with a booking on one of them, which the demo workspace does not have, and creating it would mean editing real kits in the shared workspace.
• node scripts/check-product-claims.mjs passes (543 files, no stale claims).

Impact scope

• End users affected: anyone maintaining kits that share quantity-tracked stock, and anyone whose bookings showed unexplained extra kits or a disabled Reserve button
• Prospects affected: none claimed
• Pages modified: 1
• Pages created: 1
• Pages flagged for review: 0

---

Generated by Shelf Content Intelligence — PR→Website Sync

[coderabbitai]

Warning

Review limit reached

@carlosvirreira, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 111 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14d004f9-6f33-40d3-bd2e-181d2d1334f1

📥 Commits

Reviewing files that changed from the base of the PR and between 1a67b40 and 2dc0aca.

📒 Files selected for processing (2)

• content/knowledge-base/kits.mdx
• content/updates/kit-members-reach-only-their-own-bookings.mdx

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Preview deployment

https://24c8b183.shelf-nu.pages.dev