-
Notifications
You must be signed in to change notification settings - Fork 1k
Update SPE docs to incorporate new Container Type Management APIs #10336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Learn Build status updates of commit 56452ff: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 20d5452: 💡 Validation status: suggestions
docs/embedded/getting-started/containertypes.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
Learn Build status updates of commit 96fb02d: 💡 Validation status: suggestions
docs/embedded/getting-started/containertypes.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
Learn Build status updates of commit bb54408: 💡 Validation status: suggestions
docs/embedded/getting-started/containertypes.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
bb54408 to
446825c
Compare
|
Learn Build status updates of commit 446825c: 💡 Validation status: suggestions
docs/embedded/getting-started/containertypes.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
0166259 to
5647201
Compare
|
Learn Build status updates of commit 0166259: 💡 Validation status: suggestions
docs/embedded/getting-started/containertypes.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
Learn Build status updates of commit 5647201: 💡 Validation status: suggestions
docs/embedded/getting-started/containertypes.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
Learn Build status updates of commit 7b01459: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 5953f03:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/administration/billing/billing.md | View | Details | |
| docs/embedded/administration/developer-admin/dev-admin.md | View | Details | |
| docs/embedded/getting-started/containertypes.md | View | Details | |
| docs/embedded/administration/billing/meters.md | ✅Succeeded | View | |
| docs/embedded/administration/consuming-tenant-admin/cta.md | ✅Succeeded | View | |
| docs/embedded/development/auth.md | ✅Succeeded | View | |
| docs/embedded/getting-started/register-api-documentation.md | ✅Succeeded | View | |
| docs/embedded/getting-started/spembedded-for-vscode.md | ✅Succeeded | View |
docs/embedded/administration/billing/billing.md
- Line 39, Column 85: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/administration/developer-admin/dev-admin.md
- Line 45, Column 643: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/getting-started/containertypes.md
- Line 40, Column 4: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#standard-container-types-non-trial' in 'embedded/getting-started/containertypes.md', did you mean '#standard-container-types-nontrial'?
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title for the "Pay as you go message" doesn't seem related to the description, at least to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Egress section, it says that "to the data downloaded from the SharePoint Embedded platform to the customer's client device such as a desktop or mobile device.".
We have to be a bit more careful with this, to also include the case where an SPE service application makes calls that translate into Egress, but doesn't necessarily downloads that data to any end user device.
5953f03 to
bf5a68c
Compare
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit bf5a68c:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/administration/billing/billing.md | View | Details | |
| docs/embedded/administration/developer-admin/dev-admin.md | View | Details | |
| docs/embedded/getting-started/containertypes.md | View | Details | |
| docs/embedded/administration/billing/meters.md | ✅Succeeded | View | |
| docs/embedded/administration/consuming-tenant-admin/cta.md | ✅Succeeded | View | |
| docs/embedded/development/auth.md | ✅Succeeded | View | |
| docs/embedded/getting-started/register-api-documentation.md | ✅Succeeded | View | |
| docs/embedded/getting-started/spembedded-for-vscode.md | ✅Succeeded | View |
docs/embedded/administration/billing/billing.md
- Line 39, Column 85: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/administration/developer-admin/dev-admin.md
- Line 45, Column 643: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/getting-started/containertypes.md
- Line 40, Column 4: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#standard-container-types-non-trial' in 'embedded/getting-started/containertypes.md', did you mean '#standard-container-types-nontrial'?
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
javieralvarezchiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have yet to review containertypes.md in detail.
|
Can we get a status on this PR? It's been in draft for months with no activity and now has a bunch of merge conflicts. Please either close it if it no longer applies or let us know what's going on... otherwise we'll close it next week (where you can always reopen it in the future when you're ready for a review). |
bf5a68c to
7cfb2eb
Compare
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Thanks @andrewconnell ! I'm taking this on again this week. We were waiting for the APIs to go to v1.0 and now they are ;) Expect this to go out of draft in the next few days. |
|
Learn Build status updates of commit 7cfb2eb:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/administration/billing/billing.md | View | Details | |
| docs/embedded/administration/developer-admin/dev-admin.md | View | Details | |
| docs/embedded/development/tutorials/vendor-install-app-customer.md | View | Details | |
| docs/embedded/getting-started/containertypes.md | View | Details | |
| docs/embedded/administration/billing/meters.md | ✅Succeeded | View | |
| docs/embedded/administration/consuming-tenant-admin/cta.md | ✅Succeeded | View | |
| docs/embedded/development/auth.md | ✅Succeeded | View | |
| docs/embedded/getting-started/register-api-documentation.md | ✅Succeeded | View | |
| docs/embedded/getting-started/spembedded-for-vscode.md | ✅Succeeded | View |
docs/embedded/administration/billing/billing.md
- Line 39, Column 85: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/administration/developer-admin/dev-admin.md
- Line 45, Column 643: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/development/tutorials/vendor-install-app-customer.md
- Line 24, Column 43: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-pass-through-app' in 'embedded/administration/consuming-tenant-admin/cta.md'. - Line 24, Column 207: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#pass-through' in 'embedded/administration/billing/billing.md'. - Line 62, Column 30: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#pass-through' in 'embedded/administration/billing/billing.md'. - Line 63, Column 65: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-pass-through-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/getting-started/containertypes.md
- Line 40, Column 4: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#standard-container-types-non-trial' in 'embedded/getting-started/containertypes.md', did you mean '#standard-container-types-nontrial'?
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit e30f4a3:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/administration/billing/billing.md | View | Details | |
| docs/embedded/administration/developer-admin/dev-admin.md | View | Details | |
| docs/embedded/development/tutorials/vendor-install-app-customer.md | View | Details | |
| docs/embedded/getting-started/containertypes.md | View | Details | |
| docs/embedded/administration/billing/meters.md | ✅Succeeded | View | |
| docs/embedded/administration/consuming-tenant-admin/cta.md | ✅Succeeded | View | |
| docs/embedded/development/auth.md | ✅Succeeded | View | |
| docs/embedded/getting-started/register-api-documentation.md | ✅Succeeded | View | |
| docs/embedded/getting-started/spembedded-for-vscode.md | ✅Succeeded | View |
docs/embedded/administration/billing/billing.md
- Line 42, Column 85: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/administration/developer-admin/dev-admin.md
- Line 45, Column 643: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-passthrough-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/development/tutorials/vendor-install-app-customer.md
- Line 24, Column 43: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-pass-through-app' in 'embedded/administration/consuming-tenant-admin/cta.md'. - Line 24, Column 207: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#pass-through' in 'embedded/administration/billing/billing.md'. - Line 62, Column 30: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#pass-through' in 'embedded/administration/billing/billing.md'. - Line 63, Column 65: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#set-up-billing-for-pass-through-app' in 'embedded/administration/consuming-tenant-admin/cta.md'.
docs/embedded/getting-started/containertypes.md
- Line 40, Column 4: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#standard-container-types-non-trial' in 'embedded/getting-started/containertypes.md', did you mean '#standard-container-types-nontrial'?
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit f7b944c:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/development/tutorials/vendor-install-app-customer.md | View | Details | |
| docs/embedded/administration/billing/billing.md | ✅Succeeded | View | |
| docs/embedded/administration/billing/meters.md | ✅Succeeded | View | |
| docs/embedded/administration/consuming-tenant-admin/cta.md | ✅Succeeded | View | |
| docs/embedded/administration/developer-admin/dev-admin.md | ✅Succeeded | View | |
| docs/embedded/development/auth.md | ✅Succeeded | View | |
| docs/embedded/getting-started/containertypes.md | ✅Succeeded | View | |
| docs/embedded/getting-started/register-api-documentation.md | ✅Succeeded | View | |
| docs/embedded/getting-started/spembedded-for-vscode.md | ✅Succeeded | View |
docs/embedded/development/tutorials/vendor-install-app-customer.md
- Line 24, Column 217: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#pass-through' in 'embedded/administration/billing/billing.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 180a3a5: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit ff28f16: ✅ Validation status: passed
For more details, please refer to the build report. |
Category
What's in this Pull Request?
Update SPE docs to point to new Container Type Management APIs on MSGraph instead of powershell cmdlets.