Add as_types to PostgresValues
#967
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expurple
approved these changes
Sep 2, 2025
tyt2y3
reviewed
Sep 12, 2025
| #[cfg(feature = "postgres-array")] | ||
| Value::Array(ty, _) => array_type_to_pg_type(ty), | ||
| #[cfg(feature = "postgres-vector")] | ||
| Value::Vector(_) => todo!(), |
Member
There was a problem hiding this comment.
I guess this is the reason it is still WIP?
for non built-in types I think there is no way we can statically know the type id.
which mean we need to make this function fallible (return Result) sad
Member
Author
There was a problem hiding this comment.
Yes. Perhaps we could allow users to specify the pgvector return type through a parameter.
Huliiiiii
commented
Dec 25, 2025
| #[cfg(feature = "postgres-array")] | ||
| Value::Array(ty, _) => array_type_to_pg_type(ty), | ||
| #[cfg(feature = "postgres-vector")] | ||
| Value::Vector(_) => todo!(), |
Member
Author
There was a problem hiding this comment.
How to handle the mapping of pgvector?
| #[cfg(feature = "postgres-array")] | ||
| Value::Array(ty, _) => array_type_to_pg_type(ty), | ||
| #[cfg(feature = "postgres-vector")] | ||
| Value::Vector(_) => todo!(), |
Member
Author
There was a problem hiding this comment.
Yes. Perhaps we could allow users to specify the pgvector return type through a parameter.
Member
Author
|
I totally don't know that reviews need to be submitted first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
as_typestoPostgresValues