feat: Create server and bot by Sanielia · Pull Request #1 · Sanielia/GithubProjectDiscordBot

Sanielia · 2025-09-22T14:57:56Z

No description provided.

Norbiros

What will happen if the server goes down for some time? Will everything be properly reconstructed
Why are you not using pygithub library?
Please, add a renovate bot config

github_usernames_to_discord_id_mapping.json

src/bot.py

Dockerfile

src/utils/utils.py

src/server.py

Sanielia · 2025-09-23T10:50:08Z

Why are you not using pygithub library?

do i really need a whole library to send 3 simple graphql requests?

Norbiros · 2025-09-23T11:01:45Z

Do you really need discord-py to send 10 simple http requests?
Do you really need dotenv to read one file, split it at = and store it in dictionary?
Do you really need requests, which is legacy, sync only library with dependency bload instead of something like built in requests or httpx or aiohttp?

github_id_to_discord_id_mapping.yaml

Norbiros · 2025-10-08T14:11:56Z

cwelllllll to jakib starzyk

Sanielia · 2025-11-11T22:40:01Z

todo: refactor utils (mainly dont keep them in one file)

Norbiros

I am still not sure how you want to update github_id_to_discord_id_mapping file. If a new person joins our project, you want to commit to this repository with new id and username.

.github/workflows/ci.yaml

README.md

pyproject.toml

Sanielia · 2025-11-15T13:52:16Z

I am still not sure how you want to update github_id_to_discord_id_mapping file. If a new person joins our project, you want to commit to this repository with new id and username.

we had this discussion at least once and we decided that just committing each time we add someone is good enough solution

…tItemEvent - also add RWLock for forum channel

…verification utils to separate file - create separate functions for tasks like creating post or verificating signature

- split unit tests for utils into separate files - remove integration tests which are duplicated with unit tests - in integration tests test only basic flow, without checking every possibility that may occur in every function - move all fixtures and mock classes into src/tests/utils - add tests for process method in classes inheriting from ProjectItemEvent interface in test_process

…n tests

Copilot

Pull request overview

Copilot reviewed 28 out of 36 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/utils/github_api.py:44

Syntax Error (in Python 3).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/utils/github_api.py

src/tests/test_integration/test_bot.py

src/tests/test_unit/test_bot.py

src/tests/test_e2e.py

Norbiros

idk, it might work

Sanielia requested a review from Norbiros September 22, 2025 14:59

Sanielia force-pushed the dev branch 3 times, most recently from 6e5ed57 to 3faa47d Compare September 23, 2025 08:19

Norbiros suggested changes Sep 23, 2025

View reviewed changes

Sanielia force-pushed the dev branch from 7e58774 to de510dc Compare October 6, 2025 15:35

Norbiros suggested changes Oct 8, 2025

View reviewed changes

github_id_to_discord_id_mapping.yaml Outdated Show resolved Hide resolved

Sanielia force-pushed the dev branch from 6b93153 to 6b21d38 Compare October 13, 2025 15:16

Sanielia force-pushed the dev branch 2 times, most recently from 9714857 to ca6cd9b Compare November 11, 2025 22:29

Sanielia force-pushed the dev branch from 8969468 to 48ca53c Compare November 12, 2025 08:19

Sanielia requested a review from Norbiros November 14, 2025 10:18

Norbiros suggested changes Nov 15, 2025

View reviewed changes

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

Sanielia force-pushed the dev branch from 8aa68c2 to 82fece8 Compare November 15, 2025 15:51

Sanielia requested a review from Norbiros November 17, 2025 07:19

Sanielia force-pushed the dev branch 10 times, most recently from 7004bf2 to faee2d2 Compare November 20, 2025 13:12

Sanielia force-pushed the dev branch from bd90170 to 5aa6a8e Compare November 26, 2025 18:37

Sanielia added 17 commits November 26, 2025 19:39

refactor: Move process_edition logic into interface method for Projec…

45e7574

…tItemEvent - also add RWLock for forum channel

refactor: Move bot starting and bot exception handling logic to main.py

f2188ff

refactor: Move logic out of src/utils/__init__.py

7fb0978

refactor: Remove add_bot_log_prefix function and add proper filter

b1c060d

refactor: Enforce single responsibility principle and move signature …

464d1f5

…verification utils to separate file - create separate functions for tasks like creating post or verificating signature

chore: Reformat blank lines

db280c5

refactor: Map Github item node_id to Discord post id

93913cd

chore: Remove unused import

1e75903

refactor: Proper enum instance creation

bd21e9b

fix: Remove string matching when we use enum

4457c8f

chore: Add comments informing about reason for skipping ruff checks i…

ff9bb6f

…n tests

refactor: Remove code duplication from utils.github_api

e9da762

refactor: Use global logger variable instead of passing it each time

eff874c

feat: Append link to GitHub project card in Discord post

c6a2789

refactor: Spawn task for process_update function in bot.py

0e66bb6

chore: Rename get_post_id to get_post_id_or_post

b9e87e7

Sanielia force-pushed the dev branch from 5aa6a8e to b9e87e7 Compare November 26, 2025 18:39

Sanielia requested review from Norbiros and Copilot November 26, 2025 18:48

Copilot started reviewing on behalf of Sanielia November 26, 2025 18:49 View session

Copilot finished reviewing on behalf of Sanielia November 26, 2025 18:51

Copilot AI reviewed Nov 26, 2025

View reviewed changes

src/utils/github_api.py Show resolved Hide resolved

src/tests/test_integration/test_bot.py Show resolved Hide resolved

src/tests/test_unit/test_bot.py Show resolved Hide resolved

Norbiros suggested changes Nov 28, 2025

View reviewed changes

src/tests/test_e2e.py Outdated Show resolved Hide resolved

refactor: Use conftest.py for defining fixtures

dc9ac12

Sanielia requested a review from Norbiros November 28, 2025 18:29

Norbiros approved these changes Nov 30, 2025

View reviewed changes

Sanielia merged commit 23fcea8 into master Nov 30, 2025
1 check passed

Sanielia deleted the dev branch November 30, 2025 15:22

Conversation

Sanielia commented Sep 22, 2025

Uh oh!

Norbiros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sanielia commented Sep 23, 2025

Uh oh!

Norbiros commented Sep 23, 2025

Uh oh!

Uh oh!

Norbiros commented Oct 8, 2025

Uh oh!

Sanielia commented Nov 11, 2025

Uh oh!

Norbiros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sanielia commented Nov 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Norbiros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants