[serialize] Remove redundant empty buffer#838
Merged
Conversation
This commit removes redundant empty buffer. TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
shs-park
approved these changes
Jul 23, 2026
shs-park
left a comment
shs-park
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
=)
Reviewed by AI via personal agents
Contributor
|
As I said offline, buffer[0] is special buffer in ONERT. If we don't use ONERT, this PR seems okay :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes redundant empty buffer.
Circle always use index-0 buffer for empty buffers. Currently, the tensor creation api always creates a empty buffer, which makes redundant buffers.
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com