fix: clamp theme automation interval input#336
Conversation
|
@mayurigade-hub is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github.rest.pulls.createComment does not exist in the Octokit API. Pull request comments must be posted via github.rest.issues.createComment with issue_number, since GitHub treats PRs as issues for commenting.
|
Hello @SamXop123 |
|
🎉 Congratulations @mayurigade-hub! 🎉 Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌 🚀 What's Next?
💬 Stay Connected: Thank you again, and keep up the amazing work! 💻✨ |
Related Issue
Closes #323
Description
Fixed an issue where the Theme Automation interval input could display values outside the allowed range even though the backend automatically sanitized them.
Previously, if a user entered a value such as
999, the backend correctly clamped it to120, but the input field continued to display999. This caused the UI to become inconsistent with the actual saved configuration.This fix clamps the interval value between 1 and 120 in
settings.jsand immediately updates the input field with the sanitized value before saving.Changes Made
Steps to Test
999in Check Interval (Minutes).120.0and verify it changes to1.30and verify it remains unchanged.Expected Result
Files Changed
settings.jsType of Change
☑️ Bug fix
☐ New feature
☐ Breaking change
☐ Documentation update