Conversation
v26.03.01
v26.03.02
v26.03.03
v26.05 .. Continuation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04073c0060
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| unsigned _supla_int16_t MaxSetpoint; | ||
| unsigned _supla_int16_t DefaultSetpoint; | ||
|
|
||
| unsigned char SupportedVentilationTypes; // bit mask for ventilation types |
There was a problem hiding this comment.
This field is documented as a bit mask, but the only ventilation constants are enum values 0..3. If a device advertises support by OR-ing those values, FULL | EXHAUST_ONLY becomes 3, which is indistinguishable from SUPPLY_ONLY, so clients cannot reliably decode capabilities. Please mirror SupportedControlTypes and add explicit _BIT_ constants or document that the enum is used as a bit position.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e647ae630f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c2b6013b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
HRV protocol definitions
This PR adds protocol-level definitions for a new HRV / heat recovery ventilation channel type.
The HRV channel represents the ventilation unit itself and provides a compact 8-byte runtime value with operating mode, ventilation type, setpoint, supply/exhaust output percentage and runtime flags.
The model supports common residential HRV control modes:
Schedule, temporary override, countdown timer, boost and air-quality-based control are reported as flags, not as separate operating modes.
The PR also adds HRV channel configuration with:
Auxiliary HRV components such as bypass, GHE, preheater, heater, cooler, air purifier, sensors, hood/fireplace inputs, recirculation and zones are represented as separate SUPLA channels and linked to the HRV channel through typed relations.
The relation list defines the role of each linked channel in the HRV system, while the linked channel type/function determines whether it is a control, sensor or measurement channel.
This PR is limited to protocol design and compile-time protocol checks. It does not include device logic, server logic, UI, automations or alert handling.