Remove common intg#8104
Closed
madhuriupadhye wants to merge 3 commits intoSSSD:masterfrom
Closed
Conversation
Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes several files from the integration test suite, including config.py.m4, ds.py, ds_openldap.py, and conftest.py. However, this appears to be an incomplete refactoring, as there are still dependencies on these removed files within the codebase. This will lead to build failures and numerous test failures. Specifically, the build will fail because Makefile.am still tries to generate config.py from the now-deleted config.py.m4. Additionally, multiple test files import ds_openldap, which is being removed, and will fail with ImportError. Finally, the removal of conftest.py will break tests that rely on shared pytest fixtures it provided.
pbrezina
force-pushed
the
master
branch
2 times, most recently
from
f5d64b3 to
b854636
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.