Skip to content

fix(ci): fixing 1.5 dbt tests - #6073

Merged
cmgoffena13 merged 1 commit into
SQLMesh:mainfrom
cmgoffena13:fix/dbt-1.5-ci-tests
Sep 25, 2026
Merged

cmgoffena13 merged 1 commit into
SQLMesh:mainfrom
cmgoffena13:fix/dbt-1.5-ci-tests

Conversation

@cmgoffena13

@cmgoffena13 cmgoffena13 commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Very random, the dbt 1.5 tests shows this:

echo "DBT version is 1.5 (< 1.5.0), removing version parameters..."

which is incorrect. Because the DBT version is 1.5.

So it incorrectly wires the waiter_revenue_by_day model in the tests.

Adjusted to only strip for for 1.3 and 1.4 (intended behavior)

Test Plan

CI Run. checking 1.3, 1.4, 1.5, and 1.6 to ensure they're all good.

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
@mday-io

mday-io commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

The old version check treated "1.5" as older than "1.5.0", so the dbt 1.5 job was wrongly removing the model version references. The test still passed, but it wasn't testing what it was supposed to. Listing 1.3 and 1.4 explicitly is clearer and matches the step above it. LGTM.

@cmgoffena13
cmgoffena13 merged commit 5f1911d into SQLMesh:main Sep 25, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants