Repository navigation
fix: 修复沉浸式歌词歌曲名称上下被裁剪 - #459
Open
foragedysetour wants to merge 1 commit into
Open
foragedysetour wants to merge 1 commit into
foragedysetour wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动类型
是否包含破坏性变更
改动说明
沉浸式歌词界面左侧的歌名,字的上下边缘会被削掉一点。
标题行高
leading-tight(1.25),字体 ascent + descent 通常比这高(微软雅黑约 1.31em),而SMarquee容器和PlayerData根节点都是overflow-hidden,会导致行盒外元素被裁切。改动:
SMarquee.vue:61、layouts/standard/PlayerData.vue:153的overflow-hidden换成overflow-x-clip overflow-y-visible。此次改动与 #439 不同之处是最小化修改,保留了滚动功能。
关联 Issue
Closes #438
测试情况
pnpm format、tsc --noEmit -p tsconfig.node.json、vue-tsc --noEmit -p tsconfig.web.json、eslint均通过截图 / 录屏
Before:

After:

自查清单
pnpm format,并确认pnpm typecheck、pnpm lint通过pnpm build:native验证;未手写native/*/index.d.tsdev分支提交