Title pending actions and booking rows by purpose (#63, #65) - #66
Merged
Conversation
Pending Actions and the my-rooms booking lists both led with the governing body, which is the least distinguishing thing about a row: every booking a body owns reads identically, so the summary said nothing about what the outstanding task was actually for. Both now lead with the booking's purpose -- the title someone typed for this specific booking -- and fall back to the body name only when a record has no purpose (membership requests, which have no title, keep the body name outright). lib/pending-actions.ts selects `purpose` alongside the existing embeds, so no extra round trip. An occurrence-scoped cancellation prefers that occurrence's purpose override, matching how its reference date is already resolved (#55). In my-rooms the calendar day list shows the body beside the title as secondary text; the list view's rows sit under a body heading already, so the room name takes that side slot instead of repeating the group name on every row. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63. Closes #65.
Both issues are the same complaint: rows led with the governing body, which is the least distinguishing thing about them. A body runs many bookings, so every one of its rows read identically.
Pending Actions (#63)
lib/pending-actions.tslabels now lead with the booking's purpose — the title someone typed for this specific booking — via atitleOf()helper that falls back to the body name when a record has no purpose. Membership requests have no title at all, so they keep the body name outright.purposeis added to the existing embeds (BOOKING_CHILD_SELECTand theroom_requestsselect), so there is no extra round trip. An occurrence-scoped cancellation prefers that occurrence's purpose override, matching how its reference date is already resolved (#55).Worth a look: the issue names event forms, but this applies the title to all four dated action kinds — requests, revisions, cancellations, event forms — reading "PA summary should point to event title" as the general rule. If only the two event-form kinds were meant, that is a two-line revert.
my-rooms booking rows (#65)
Verification
npx tsc --noEmitclean andnpm run buildsucceeds.npm run lintreports 14 errors that are all pre-existing ondev; none are in files this branch touches. The authenticated views were not exercised in a browser.Note
This branch and the #64 branch both touch
lib/pending-actions.ts— different hunks (labels and the requests select here; the signature and the memberships query there), but whichever merges second is worth a rebase check.🤖 Generated with Claude Code