Conversation
dburgener
reviewed
Apr 9, 2025
| count=$(echo ${output} | grep -o "W-002" | wc -l) | ||
| echo "Status: $status, Count: $count (expected 1)" | ||
| echo $output | ||
| echo ${output} |
Member
There was a problem hiding this comment.
Shouldn't this and the remaining echo calls in this function just be dropped? It looks like it's just printing the same output four times in a row.
Contributor
Author
There was a problem hiding this comment.
true, dropped superfluous statements
| count=$(echo ${output} | grep -o "W-002" | wc -l) | ||
| echo "Status: $status, Count: $count (expected 0)" | ||
| echo $output | ||
| echo ${output} |
Member
There was a problem hiding this comment.
As above, this one now seems redundant to the one above.
Member
There was a problem hiding this comment.
(In this case, the subsequent ones in the function all follow a run, so for this test, it's just this line that I think needs dropping).
Dump the output of invoked commands in the functional tests, so that they are shown when the testcase fails, to ease debugging. (The output is not shown in case the testcase succeeds.) Inspired due to a valgrind failure on armhf on Debian buildd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dump the output of invoked commands in the functional tests, so that they are shown when the testcase fails, to ease debugging. (The output is not shown in case the testcase succeeds.)
Inspired due to a valgrind failure on armhf on Debian buildd.