Skip to content

Conversation

@kjplows
Copy link

@kjplows kjplows commented Dec 26, 2025

CAFMaker configuration chokes if this guard isn't enabled.

The culprit is in NuclearModelMap::LoadConfig(), that checks NuclearModel@Pdg=...., as that calls GetConfig() and loops over all entries in GetItemMap(), which expands keys (such as the expected ones e.g. NuclearModel@Pdg=1000180400), treats them like algs, evaluates their config (in this case, SpectralFunc/ApproxElements for the AR25_20i_00_000 tune), and appends keys from that config.

This creates bogus keys like NuclearModel@Pdg=1000180400/AllowElementMatch, which cause UB and segfault.
A tag, v3_06_02_sbn1p1, has been created pointing to commit 7e784bc, and published to SBN CVMFS.
Production workflows using this tag have run successfully on the grid.

Summoning @sjgardiner (who setup most of this original magic 🪄) to review.

Ho Ho Ho! 🎅🌲❄️

@kjplows kjplows requested a review from sjgardiner December 26, 2025 08:45
@kjplows kjplows self-assigned this Dec 26, 2025
@kjplows kjplows added the bug Something isn't working label Dec 26, 2025
@kjplows
Copy link
Author

kjplows commented Jan 8, 2026

Given this runs end-to-end on production and based on Slack conversations with @sjgardiner I am merging this

@kjplows kjplows merged commit a7412b7 into v3_06_02_br Jan 8, 2026
@kjplows kjplows moved this from Done to Recently done in SBN software development Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Recently done

Development

Successfully merging this pull request may close these issues.

2 participants