Fix Windows user-level installation (0.8.2) - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows installation can fail with an elevation-required error while probing the staged executable, and a successful install previously left PowerShell suggestions disconnected.
This change embeds an explicit asInvoker manifest, uses a neutral staging name, rejects a failed startup probe before replacement, keeps Windows PowerShell 5.1 script encoding safe, and makes accepted setup connect PowerShell plus enable local suggestions. It also normalizes Windows verbatim paths before writing the shell profile.
Coverage includes resource-level manifest validation and an end-to-end installation under a standard Windows account. The test launches a fresh PowerShell 7 profile, verifies the Ctrl+F handler, obtains a real directory suggestion, and confirms that a failed update preserves the existing binary. Includes 0.8.2 release metadata.