fix: await abortTask in cancelTask to prevent content loss #10097
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10093
Description
This PR attempts to address Issue #10093 where canceling a task during an API request causes content loss.
Root Cause: In
cancelTask(),task.abortTask()was called withoutawait. TheabortTask()method saves messages to disk asynchronously, but since it was not awaited,createTaskWithHistoryItem()would fetch the history before the messages were persisted.Fix: Added
awaitto thetask.abortTask()call to ensure messages are properly saved to disk before attempting to rehydrate the task from history.Test Procedure
ClineProvider.spec.ts- All 99 tests passClineProvider.flicker-free-cancel.spec.ts- All 4 tests passPre-Submission Checklist
Screenshots / Videos
N/A - This is a backend fix with no UI changes.
Documentation Updates
Additional Notes
Feedback and guidance are welcome.