Skip to content

Conversation

@lmtr0
Copy link

@lmtr0 lmtr0 commented Dec 14, 2025

Related GitHub Issue

Closes: #10079

Description

  • Implements a new command to start a new task without prompting the user when the command is invoked
  • Adds translations for the new command
  • Adds necessary changes for the command to work:
    • package.json, package.nls.json, .....
  • adds tests for the new command

Test Procedure

  • leveraged ai to write tests

Screenshots / Videos

there are no ui changes

Documentation Updates

I have not written the documentation changes

Get in Touch

lmtr0


Important

Adds newTask.noPrompt command to create tasks without prompts, with translations and keybindings.

  • Behavior:
    • Adds newTask.noPrompt command in registerCommands.ts to create tasks without user prompts.
    • Registers newTask.noPrompt in package.json with keybinding ctrl+m ctrl+n.
  • Translations:
    • Adds command.newTask.noPrompt.title to package.nls.json and 18 other language files.

This description was created by Ellipsis for d7dde44. You can customize this summary. It will automatically update as commits are pushed.

@lmtr0 lmtr0 requested review from cte, jr and mrubens as code owners December 14, 2025 17:51
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Enhancement New feature or request labels Dec 14, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 14, 2025

Rooviewer Clock   See task on Roo Cloud

Reviewed PR #10080. Found 2 suggestions for improvement:

  • Refactor duplicate code in newTask.noPrompt handler (identical to plusButtonClicked)
  • Fix inconsistent indentation in package.json (uses spaces instead of tabs)

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Comment on lines +154 to +169
"newTask.noPrompt": async () => {
const visibleProvider = getVisibleProviderOrLog(outputChannel)

if (!visibleProvider) {
return
}

TelemetryService.instance.captureTitleButtonClicked("plus")

await visibleProvider.removeClineFromStack()
await visibleProvider.refreshWorkspace()
await visibleProvider.postMessageToWebview({ type: "action", action: "chatButtonClicked" })
// Send focusInput action immediately after chatButtonClicked
// This ensures the focus happens after the view has switched
await visibleProvider.postMessageToWebview({ type: "action", action: "focusInput" })
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is identical to plusButtonClicked (lines 88-103). Consider extracting the shared logic into a helper function to avoid duplication and simplify future maintenance. For example:

const handlePlusAction = async () => {
	const visibleProvider = getVisibleProviderOrLog(outputChannel)
	if (!visibleProvider) return
	TelemetryService.instance.captureTitleButtonClicked("plus")
	await visibleProvider.removeClineFromStack()
	await visibleProvider.refreshWorkspace()
	await visibleProvider.postMessageToWebview({ type: "action", action: "chatButtonClicked" })
	await visibleProvider.postMessageToWebview({ type: "action", action: "focusInput" })
}

Then both commands could use: plusButtonClicked: handlePlusAction, "newTask.noPrompt": handlePlusAction

Fix it with Roo Code or mention @roomote and request a fix.

Comment on lines +173 to +177
{
"command": "roo-cline.newTask.noPrompt",
"title": "%command.newTask.noPrompt.title%",
"category": "%configuration.title%"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting issue: these lines use 4 spaces for indentation while the rest of the file uses tabs. This inconsistency also appears in the new keybinding entry (lines 301-306). Consider reformatting to use tabs for consistency.

Fix it with Roo Code or mention @roomote and request a fix.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] New command new task without prompting

2 participants