Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When no layout of a Mermaid diagram fits, leaf falls back to its source (#288). The block header now says why and how wide the terminal needs to be:
mermaid::renderreturnsResult<String, Fallback>;Fallback::TooWidecarries the width of the narrowest layout it tried.mermaidheader.Why
The fallback is silent, so a diagram that is only too wide looks like unsupported Mermaid. I hit this with a flowchart and a state diagram that need 256 and 212 columns.
How it was tested
markdown_embedded.rs: the reported width is exact (one column less falls back, the reported width renders), the header fits at widths 20 to 60, and unsupported diagrams get no note.cargo test,cargo clippy --all-targets --all-features -- -D warnings,cargo build --release.