fix: initialize Request::sortMode (was uninitialized) - #39
Open
weasel0x00 wants to merge 1 commit into
Open
Conversation
sortMode was never set in the constructor, so a run without -S read indeterminate stack memory and could nondeterministically take the multiple-sort (time-seeded shuffle) path. Default it to REQUEST_SINGLE_SORT so single-sort runs are reproducible. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request::sortModewas never initialized in the constructor, so the default placement path read an indeterminate value. This initializes it toREQUEST_SINGLE_SORT.Standalone one-line bug fix — safe to merge on its own. (Also included in the larger #38 series, but pulled out here so it can be taken independently.)