feat: add denomination_symbol and display_decimals metadata to Offering

[Keengfk]

feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.

▸ Credits: 0.35 • Time: 15s
feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.

▸ Credits: 0.35 • Time: 15s
feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.

▸ Credits: 0.35 • Time: 15s
feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.

▸ Credits: 0.35 • Time: 15s
feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.

▸ Credits: 0.35 • Time: 15s
feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.

▸ Credits: 0.35 • Time: 15s
feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.

▸ Credits: 0.35 • Time: 15s
feat: add denomination_symbol and display_decimals to Offering metadata

Problem

Indexers, wallets, and dashboards had no on-chain source of truth for how to display payout
amounts. They were forced to guess display precision and currency labels from the payment token
address, which is unreliable and fragile across different asset types.

Solution

Add two new fields to the Offering struct at registration time:

• denomination_symbol: Symbol — human-readable ticker (e.g. USDC, XLM) for the payout
  denomination
• display_decimals: u32 — decimal precision wallets should use when rendering amounts

Both fields are written to persistent storage and included in the ofr_reg2 event payload, so
indexers get everything they need from a single event with no extra round-trips.

Changes

Core (src/lib.rs)

• RevoraError: new variant DisplayDecimalsOutOfRange = 51 — emitted when display_decimals > 18
• Offering struct: added denomination_symbol and display_decimals fields
• DataKey2: new DenominationMetadata(OfferingId) storage key for O(1) targeted reads
• register_offering: two new trailing parameters with eager validation (display_decimals ≤
  MAX_TOKEN_DECIMALS) checked before the duplicate-prevention guard
• Storage: DenominationMetadata written alongside OfferItem and OfferingRecord
• ofr_reg2 event: both emit calls updated to include the new fields in payload
• get_denomination_metadata: new read-only helper returning Option<(Symbol, u32)>

Call sites

• All 346 existing register_offering / try_register_offering calls across 28 test files updated
  with &symbol_short!(""), &0 defaults — no behaviour change for existing tests

Tests (src/test.rs) — 9 new

┌──────┬──────────────────┐
│ Test │ What it verifies │
├───────────────────────────────────────────┼──────────────────┤
│ denomination_metadata_stored_an │ Happy path — symbol and decimals round-trip │
│ d_readable │ through storage │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_zero_deci │
│ mals_accepted │ │
├──────────────────────────────────────┼───────────────────────────────────────────────────┤
│ denomination_metadata_max_decim │ Boundary: display_decimals = 18 is valid │
│ als_accepted │ │
├───────────────────────────────────────────┼──────────────────────────────────────────────┤
│ denomination_metadata_rejects_displa │
│ lay_decimals_over_18 │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_rejects_disp │
│ lay_decimals_u32_max │ DisplayDecimalsOutOfRange │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_returns_none │
│ before_register │ unknown offering │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_in_ofr_reg2 │
│ event_payload │ │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_reflected_in │
│ _get_offering │ fields │
├─────────────────────────────────────────┼────────────────────────────────────────────────┤
│ denomination_metadata_validation_b │
│ ion_before_duplicate_guard │ no-ops on an existing offering │
└────────────────────────────────────┴─────────────────────────────────────────────────────┘

Security notes

• denomination_symbol is informational only — it has no effect on payout math, token transfers,
  or authorization
• display_decimals ≤ payment_token_decimals is a caller responsibility documented in the
  function doc-comment; enforcing it on-chain would require a cross-contract call that adds gas
  and complexity for no security benefit
• Validation order: supply_cap → display_decimals → revenue_share_bps → duplicate guard — all
  parameter errors surface eagerly before any state is written
• Error code 51 is new and wire-stable; all existing error discriminants are unchanged

Backward compatibility

Existing on-chain state is unaffected. The new fields default to symbol_short!("") and 0 for
any offering registered before this version. The ofr_reg2 event payload is additive — existing
indexers that only read the first three fields continue to work.
closes #475

[drips-wave]

@Keengfk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits