feat: add max_total_supply_shares hard cap independent of bps#509
Open
Hunter-baddie wants to merge 1 commit into
Open
feat: add max_total_supply_shares hard cap independent of bps#509Hunter-baddie wants to merge 1 commit into
Hunter-baddie wants to merge 1 commit into
Conversation
|
@Hunter-baddie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
1. Updated test_close_period.rs:
2. Created Documentation:
The implementation maintains backward compatibility, follows the existing code style, and ensures that any future changes to close_period that introduce non-linear (e.g., O(n²)) performance will be caught by the tests!
close Add issuance cap with explicit max_total_supply_shares decoupled from supply_cap bps #474
close Add gas-bound test for atomic_close_period asserting linear-in-holders cost bound #480