test: add focused behavior coverage for SessionRepositoryAdapter - #1184
Merged
thlpkee20-wq merged 1 commit intoSep 29, 2026
Merged
thlpkee20-wq merged 1 commit into
thlpkee20-wq merged 1 commit into
Conversation
The login module's SessionRepositoryAdapter had no directly associated test fixture, so its camelCase-to-snake_case mapping, void return contract and error propagation were unprotected against regression. Pin those behaviors (including boundary/abuse inputs and DB failure paths) with focused tests so any change to the adapter's public contract fails loudly. Refs RevoraOrg#968 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@Adesh-tech09 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #968
What changed
src/auth/login/sessionRepositoryAdapter.test.ts— the dedicated fixture thatsrc/auth/login/sessionRepositoryAdapter.tswas missing.Covered behavior
SessionRepositoryAdapterstays assignable to the login module'sSessionRepositoryinterface{ id, user_id, token_hash, expires_at }Dateinstance is passed throughundefined; the persisted row is discardedDateexpiry are forwarded verbatim for the DB layer to rejectValidation
npx jest src/auth --runInBand→ 260 passed; the single failure insrc/auth/register/__tests__/roundtrip.test.tsis pre-existing onmasterand untouched by this PR.npx eslint src/auth/login/sessionRepositoryAdapter.test.ts→ clean.Security notes / assumptions
token_hash).🤖 Generated with Codebuff