feat: add atbash, octal, decimal and binary plugins#102
Open
berzerk0 wants to merge 3 commits intoReversecLabs:mainfrom
Open
feat: add atbash, octal, decimal and binary plugins#102berzerk0 wants to merge 3 commits intoReversecLabs:mainfrom
berzerk0 wants to merge 3 commits intoReversecLabs:mainfrom
Conversation
Added atbash plugin, simple substitution cipher Added simple encoding plugins: octal, decimal, binary_in_ascii. Fixed spelling of Caesar. Added notes about shift and rot13 Atbash, octal, and decimal have hints by default in output - Hello -> "atbash svool"
Removed unnecessary items
removed incorrect description
ThomasCross
changed the title
Collaborator
|
Nice first PR, code lgtm 🎉 However please can you update 'Built-in Plugins' table in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added atbash plugin, simple substitution cipher
Added simple encoding plugins: octal, decimal, binary_in_ascii.
Fixed spelling of Caesar. Added notes about shift and rot13. Converted to BasicPlugin.
Atbash, octal, and decimal have hints by default in output. User can disable hints with plugin options.
For "Hello", the result is
octal 110 145 154 154 157atbash Svooldecimal 72 101 108 108 111