p3i2psam3: Fix mutex copying bug causing crash on Windows#271
Merged
csoler merged 1 commit intoRetroShare:masterfrom Feb 24, 2026
Merged
p3i2psam3: Fix mutex copying bug causing crash on Windows#271csoler merged 1 commit intoRetroShare:masterfrom
csoler merged 1 commit intoRetroShare:masterfrom
Conversation
jolavillette
force-pushed
the
Fix_p3i2psam3
branch
from
a94934a to
3e6b2ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The code was incorrectly performing a bitwise copy of an RsMutex object before locking it:
auto l = this->mLockSam3Access; // Error: Creates a copy
RS_STACK_MUTEX(l);
On Windows/MinGW, copying a mutex is invalid and causes pthread_mutex_lock to return EINVAL. This triggers a logging path that crashes in ntdll!RtlAllocateHeap.
Fix
Lock the mutex member directly instead of using an intermediate variable. This ensures correct synchronization and prevents the EINVAL error and the subsequent fatal chain reaction on Windows.