Fix init script for PostgreSQL 18 compatibility#3
Open
leroytang-redis wants to merge 1 commit intoRedislabs-Solution-Architects:mainfrom
Open
Fix init script for PostgreSQL 18 compatibility#3leroytang-redis wants to merge 1 commit intoRedislabs-Solution-Architects:mainfrom
leroytang-redis wants to merge 1 commit intoRedislabs-Solution-Architects:mainfrom
Conversation
The hardcoded PGDATA path (/var/lib/postgresql/data) doesn't work with PostgreSQL 18, which uses /var/lib/postgresql/18/docker. This fix uses the container's $PGDATA environment variable instead, making it compatible with all PostgreSQL versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PostgreSQL 18 Compatibility Issue
Problem
The initialization script fails on PostgreSQL 18 because it uses a hardcoded path to
postgresql.confthat doesn't exist:PostgreSQL 18 uses
/var/lib/postgresql/18/dockerinstead of/var/lib/postgresql/data, causing the script to fail with:This prevents the Chinook database from being initialized and populated.
Solution
Use the container's
$PGDATAenvironment variable instead of hardcoding the path. This makes the script compatible with all PostgreSQL versions.Testing
Tested with:
Changes
scripts/init_docker-postgres.shto use$PGDATAenvironment variable