feat: Add "network" field to LlamaStackDistribution #2637
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Garcia Oncins <[email protected]>
WalkthroughThis PR adds an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ocp_resources/llama_stack_distribution.py (1)
16-49: Generated code edited directly—update the generator instead.These changes are inside the generated-code block; per guidelines, modifications must be made in the class-generator and regenerated rather than editing the output file. As per coding guidelines, please update the generator and regenerate.
Collaborator
|
@jgarciao did you add it manually or update with class-generator? |
Author
|
I updated the file manually, as following the process below didn't work for me. It is very likely that I'm missing some step, as it is the first time for me running this, but currently what happens is that the file ocp_resources/llama_stack_distribution.py is just reformatted but the new Setup env: This command modifies the existing file ocp_resources/llama_stack_distribution.py but it is just reformatting the imports section, the new "network" field added in RHOAI 3.3 is not being added I've tried also updating the schema and generating again the LlamaStackDistribution resource, but again, the new field wasn't added |
Collaborator
when you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
Adding the new
networkfield to LlamaStackDistribution, which was added recently at github.com/llamastack/llama-stack-k8s-operator/pull/221)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.