Add Host to FeatureFlags hostname configuration

[ezr-ondrej]

Host needs to be configured for Ingress to set route.

Add predictable Frontend token for external readonly authentication

Summary by Sourcery

Configure hostname for Feature Flags Ingress and add a frontend access token for external readonly authentication

New Features:

• Add a predictable frontend access token for external readonly authentication

Enhancements:

• Update Feature Flags Ingress to use dynamically generated hostname
• Modify Ingress path from '/api/client/features' to '/api/frontend'

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request configures the Host for FeatureFlags Ingress to set the route. It adds a frontend access token, configures the Ingress resource with a host, and generates/sets the hostname for the environment if it's empty.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Adds a frontend access token to the default Feature Flags secret map.	Adds a frontendAccessToken to the createDefaultFFSecMap function, with a default value of *:development.proxy-123.	controllers/cloud.redhat.com/providers/featureflags/localfeatureflags.go
Adds the frontend access token to the environment variables.	Adds INIT_FRONTEND_API_TOKENS to the environment variables, sourced from the frontendAccessToken in the secret.	controllers/cloud.redhat.com/providers/featureflags/localfeatureflags.go
Configures the Ingress resource with a host and updates the path.	Sets the Ingress Host to the environment's hostname. Updates the Ingress Path from /api/client/features to /api/frontend.	controllers/cloud.redhat.com/providers/featureflags/localfeatureflags.go
Generates and sets the hostname for the environment if it is empty.	Checks if the environment's hostname is empty. If the hostname is empty, it generates a new hostname using Env.GenerateHostname. Updates the environment's status with the new hostname.	controllers/cloud.redhat.com/providers/featureflags/localfeatureflags.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ezr-ondrej - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the hostname update logic into a separate function for better readability.
• It might be worth adding a comment explaining why the frontendAccessToken is hardcoded.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[maknop]

/retest

[ezr-ondrej]

/retest

[maknop]

/retest

[maknop]

Spoke to @ezr-ondrej already about the failing test. Will review once that gets resolved. 😄