Skip to content

Conversation

@ben-schwen
Copy link
Member

Follows #7487 and removes the following compile warnings

assign.c: In function ‘assign’:
assign.c:368:26: warning: unused variable ‘tc2’ [-Wunused-variable]
  368 |   const char *c1, *tc1, *tc2;
      |                          ^~~
assign.c:368:20: warning: unused variable ‘tc1’ [-Wunused-variable]
  368 |   const char *c1, *tc1, *tc2;
      |                    ^~~
assign.c:368:15: warning: unused variable ‘c1’ [-Wunused-variable]
  368 |   const char *c1, *tc1, *tc2;
      |               ^~
assign.c:365:56: warning: unused variable ‘a’ [-Wunused-variable]
  365 |   SEXP targetcol, nullint, s, colnam, tmp, key, index, a, assignedNames;
      |                                                        ^
assign.c:365:28: warning: unused variable ‘s’ [-Wunused-variable]
  365 |   SEXP targetcol, nullint, s, colnam, tmp, key, index, a, assignedNames;
      |                            ^
dogroups.c: In function ‘dogroups’:
dogroups.c:80:58: warning: unused variable ‘s’ [-Wunused-variable]
   80 |   SEXP ans=NULL, jval, thiscol, BY, N, I, GRP, iSD, xSD, s, RHS, target, source;
      |                                                          ^


@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (9029d79) to head (0c25126).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7578   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          87       87           
  Lines       16758    16758           
=======================================
  Hits        16595    16595           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
Copy link
Member Author

Merging since its non user facing, non changing behavior.

@ben-schwen ben-schwen merged commit ee23077 into master Jan 9, 2026
13 checks passed
@ben-schwen ben-schwen deleted the unused_vars branch January 9, 2026 08:56
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

No obvious timing issues in HEAD=unused_vars
Comparison Plot

Generated via commit 0c25126

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 20 seconds
Installing different package versions 11 minutes and 15 seconds
Running and plotting the test cases 3 minutes and 41 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant