Restore miner-burn emission scaling - #3071
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny by account tier (40-day-old account, zero public repos), mitigated by repository write access and substantive merged history; no Gittensor association found. Branch fix/restore-miner-burn-scaling -> main. FindingsNo findings. ConclusionStatic analysis found no malicious behavior or security vulnerability. The bounded fixed-point change restores the prior miner-burn scaling formula, safely handles zero aggregate weight, preserves the AI review trust boundary, and includes the required runtime version bump. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN; established repository contributor with write access and substantial recent subtensor contributions. Description discrepancyThe branch bumps Findings
Other findings
Prior-comment reconciliation
ConclusionThe runtime change is coherent, uses safe fixed-point arithmetic, and is adequately tested. The stale PR-body statement is non-blocking but should be corrected. 📜 Previous run (superseded)
|
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
29ee1b8 to
aec9c86
Compare
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
Restore the miner-burn adjustment to cross-subnet emission allocation. A subnet’s normalized EMA-price share should be scaled by the portion of miner incentive that was not withheld, so subnet-owner-directed miner emission affects its network-wide allocation regardless of whether that value is recycled or burned.
Changes
price_share × (1 − MinerBurned)weighting inpallets/subtensor/src/coinbase/subnet_emissions.rs.MinerBurnedindependent of the subnet’sRecycleOrBurnconfiguration.Economic behavior
For subnet
i, the runtime computes:MinerBurnedis clamped to one and all runtime arithmetic uses saturating fixed-point operations. If all adjusted weights are zero, allocation reverts to normalized EMA-price shares.Files of interest
pallets/subtensor/src/coinbase/subnet_emissions.rspallets/subtensor/src/coinbase/run_coinbase.rspallets/subtensor/src/tests/subnet_emissions.rsdocs/concepts/emissions.mdxwebsite/apps/bittensor-website/src/lib/emission-math.tsTesting
Added regression coverage for unequal miner-burn values, a fully burned subnet, and the all-subnets-fully-burned fallback.
Runtime and migration impact
This changes runtime economic behavior but introduces no storage migration. The existing runtime
spec_versionis 444, above the referenced Finney snapshot version 443, so no additional bump is required for themain-branch check.