[DRAFT] Shared/aggregate load#804
Draft
alefimov-amd wants to merge 51 commits into
Draft
Conversation
alefimov-amd
marked this pull request as draft
May 21, 2025 15:03
alefimov-amd
force-pushed
the
shared/aggregate_load
branch
from
May 22, 2025 20:13
347992c to
6c36ed1
Compare
antiagainst
force-pushed
the
shared/triton-gfx950-launch
branch
from
May 26, 2025 17:58
77c00fa to
a259f0a
Compare
IR is ready, need to debug correctness issue
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
- Generalize implementation to handle case where shared memory cannot hoist entire operand A. (taking into account size of operand B) - Fix stream pipeliner prologue to hoist out of nested loop by setting location to src pointer. Signed-off-by: Stanley Winata <stanley.winata@amd.com>
alefimov-amd
force-pushed
the
shared/aggregate_load
branch
from
May 29, 2025 21:35
c65837e to
5e47bef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces AggregateLoad pass, which aggregates multiple small loads inside a loop in one wide load and moves it it outeerloop:
transforms to:
In case all iterations could be aggregated, outer loop is not created.
For now application of this pass is limited to scale parameters of scaled_dot operation.