hip-tests: skip peer-device graph test when hipErrorNotSupported

[sunhmy-amd]

Motivation

On systems where hipDeviceCanAccessPeer returns true (e.g., gfx1250 with AIFM
fabric), Unit_hipGraphAddMemcpyNode1D_Functional's peer device section proceeds
to call hipGraphInstantiate, which fails with hipErrorNotSupported (error 801)
because multi-device graphs are not yet supported on either the classic or segmented
graph scheduling paths in CLR. The test hard-fails rather than skipping, producing
a misleading failure on otherwise healthy systems.

Technical Details

In validateMemcpyNode1DArray, replace the unconditional
HIP_CHECK(hipGraphInstantiate(...)) in the peer device path with an explicit
return-code check. When hipGraphInstantiate returns hipErrorNotSupported, clean
up allocated resources and call SKIP() (Catch2 v3.3+) instead of failing. All
other error codes continue through HIP_CHECK as before.

The root cause is a known CLR limitation documented in both
GraphExecClassic::Init() and GraphExecSegmented::FindStreamsReqPerDevForSegments():
[hipGraph] Multi-device graph is not supported on the segment scheduling path

The fix is test-side only. validateMemcpyNode1DArray is static and called from
exactly three SECTION blocks within a single test case; the new code path triggers
only on hipErrorNotSupported, leaving the single-device sections unaffected.

JIRA ID

ROCM-28108

Test Plan

Rebuilt GraphsTest1 from the patched source on a gfx1250 system with AIFM fabric
active (4 GPUs, all ACCEL_STATE: READY), with PRs #8254 and #8534 applied to
CLR/ROCr. Ran with AMD_COMGR_HOTSWAP_ENTRY_TRAMPOLINES=1 HSA_ENABLE_SDMA=1,
all 4 GPUs visible.

Test Result

Test	Before	After
Unit_hipGraphAddMemcpyNode1D_Functional (default device)	Passed	Passed
Unit_hipGraphAddMemcpyNode1D_Functional (peer device)	Failed (801)	Skipped

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[therock-pr-bot]

❌ PR Check — Action Required

Check	Status	Details
🌿 Branch Name	❌ Fail	Branch name does not match allowed patterns. Branch: mingsun/fix-multigpu-graph-skip Allowed patterns: - ^users\/[A-Za-z0-9][A-Za-z0-9\-]*\/.+ - ^shared\/.+ - ^[A-Za-z0-9][A-Za-z0-9\-_]*$ - ^dependabot\/.+ - ^revert-[0-9]+-.+
📝 PR Title/Description	❌ Fail	Error: Title does not follow Conventional Commits style. Expected: start with a valid type (feat, fix, docs, …). Desired format: type(optional-scope): short description
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	❌ Fail	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/hip-tests/catch/unit/graph/hipGraphAddMemcpyNode1D_old.cc; no test file found
🔎 pre-commit	⏳ Pending	⏳ Still running…
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

⚠️ 3 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

• ❌ Branch Name
• ❌ PR Title/Description
• ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

[therock-pr-bot]

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

• ❌ Branch Name
• ❌ PR Title/Description
• ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

[Copilot]

Pull request overview

Updates the HIP graph memcpy 1D functional test to avoid reporting a hard failure on platforms where multi-device graph instantiation is not supported, by converting a specific instantiation failure into a test skip.

Changes:

• Replaces unconditional HIP_CHECK(hipGraphInstantiate(...)) with an explicit return-code check.
• On hipErrorNotSupported, performs cleanup and skips the test instead of failing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.