Skip to content

Jungx098/validate only - #8392

Closed
jungx098 wants to merge 9 commits into
developfrom
jungx098/validate_only
Closed

Jungx098/validate only#8392
jungx098 wants to merge 9 commits into
developfrom
jungx098/validate_only

Conversation

@jungx098

@jungx098 jungx098 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Motivation

Technical Details

JIRA ID

Test Plan

Test Result

Submission Checklist

jungx098 and others added 9 commits March 14, 2026 19:21
@jungx098
refactor: Remove validateOnly from bind APIs
89d39ce 
- Drop validateOnly param from bindExternalDevice and
  unbindExternalDevice across device base and subclasses
- Remove VALIDATE_ONLY constants from HIP GL and OpenCL
  interop callers
- Simplify conditional error logging in PAL device
@jungx098
refactor: Decouple GL interop begin/end from bind
28b115f 
- Move wglBeginCLInteropAMD/wglEndCLInteropAMD out of
  glAssociate/glDissociate into new beginGLInterop/endGLInterop
  device virtual methods with PAL and ROCm overrides
- Add Context-level interop tracking with HGLRC change
  handling, called from hipGLGetDevices and ~Context
- Remove unbindExternalDevice from ~Context; call
  beginGLInterop after bindExternalDevice in create
@jungx098
Merge branch 'develop' into jungx098/validate_only
1b72632
@jungx098
Merge branch 'develop' into jungx098/validate_only
0426291
@jungx098
refactor: Move GL interop begin/end to GLFunctions
72d7693 
- Remove beginGLInterop/endGLInterop from Device and all subclasses
- Add beginCLInterop/endCLInterop to GLFunctions with lazy
  function pointer loading via GetProcAddress_
- Update Context to route interop calls through glenv_

Made-with: Cursor
@jungx098
refactor: Move GL function pointers to shared GLFunctions
b572725 
- Consolidate GL interop function typedefs and loading from
  PAL/ROCm device backends into platform/interop_gl
- Replace direct function pointer calls with GLFunctions
  static accessors across PAL and ROCm GL interop code
- Remove duplicated initGLInteropPrivateExt implementations

Made-with: Cursor
@jungx098
refactor: Reuse GLFunctions for AMD interop init
2e6b603 
- Move AMD interop symbol resolution into GLFunctions
  constructor, reusing its library handle and GetProcAddress
- Remove standalone initAMDInterop static method and its
  redundant GL library loading
- Hoist GLFunctions creation earlier in Context::create
  to cover all GL interop paths
@jijung
Merge remote-tracking branch 'public/develop' into jungx098/validate_…
40688ea 
…only
@jungx098
fix: Lower glAssociate failure log level in CLR
402d95f 
- PAL/ROCm bindExternalDevice now logs glAssociate misses at info
- Avoids false-positive errors during GL interop enumeration paths
@therock-pr-bot

therock-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ❌ Fail Branch name does not match allowed patterns.
Branch: jungx098/validate_only
Allowed patterns:
- ^users\/[A-Za-z0-9][A-Za-z0-9\-]*\/.+
- ^shared\/.+
- ^[A-Za-z0-9][A-Za-z0-9\-_]*$
- ^dependabot\/.+
- ^revert-[0-9]+-.+
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
───
Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/clr/hipamd/src/hip_gl.cpp, projects/clr/opencl/amdocl/cl_d3d10.cpp, projects/clr/opencl/amdocl/cl_d3d11.cpp, projects/clr/opencl/amdocl/cl_d3d9.cpp, projects/clr/opencl/amdocl/cl_gl.cpp (+11 more); no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 3 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ Branch Name
  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ Branch Name
  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@jungx098

jungx098 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #8421 (branch renamed to comply with naming policy).

@jungx098 jungx098 closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Not ready to Review organization: ROCm project: clr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jungx098 @jijung