test(rccl): Add doneEvent stream-ordering unit tests - #8383
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
|
Unit Test checks by PR bot not applicable for RCCL. |
d1bc35e to
1078c5d
Compare
There was a problem hiding this comment.
Pull request overview
Adds new RCCL unit tests that reproduce and guard against a single-stream fast-launch doneEvent stream-ordering regression (hang / incorrect ordering after checkpoint-like teardown/reinit), and wires them into CI precheckin.
Changes:
- Added
DoneEventOrderingTests.cppwith six process-isolated gtest cases covering alternating streams, reinit cycles, grouped calls, default-stream transitions, and lazy stream-switch behavior. - Registered the new test file in
projects/rccl/test/CMakeLists.txtso it builds intorccl-UnitTests. - Added the six tests to
ci-precheckin.jsonso they run in CI with explicit per-test timeouts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/rccl/tools/scripts/test_runner/configs/ci-precheckin.json | Adds CI entries for the six new DoneEventOrdering tests. |
| projects/rccl/test/DoneEventOrderingTests.cpp | New process-isolated unit tests targeting doneEvent stream-ordering correctness. |
| projects/rccl/test/CMakeLists.txt | Includes the new test source in the unit test build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1078c5d to
cf6c484
Compare
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Rahul Vaidya <ravaidya@amd.com>
cf6c484 to
f4c17fb
Compare
Motivation
Adds CI unit tests for the post-checkpoint RCCL hang caused by a dropped doneEvent ordering edge in the single-stream fast launch path.
Technical Details
Six process-isolated tests in DoneEventOrderingTests.cpp, registered in rccl-UnitTests and wired into ci-precheckin.json:
JIRA ID
JIRA ID: AICOMRCCL-1301
Test Plan
Run rccl-UnitTests --gtest_filter='DoneEventOrdering.*' on a multi-GPU node.
Test Result
All 6 tests pass on banff (8-GPU MI300X, ROCm 7.2, RCCL 2.30.4), ~52 s total.
Submission Checklist