Add dynamic pip URL selection to TheRock manylinux dockerfile.#481
Merged
Conversation
(cherry picked from commit 209ee9e)
magaonka-amd
approved these changes
Jun 29, 2026
magaonka-amd
left a comment
magaonka-amd
left a comment
Contributor
There was a problem hiding this comment.
okay I tested this yesterday in my branch it works. hence the fast approval :) thanks
tsrw2048
added a commit
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Rock CI has a pip index URL with a different format than the nightly build index. This PR allows for dynamic selection based on the URL passed in (identified by a *.html suffix). This PR is required for future JAX releases to be integrated with TheRock CI.
Changes
Changes contained to docker/manylinux/Dockerfile.jax-manylinux_2_28-therock