Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up rocMLIR build warnings by updating a few MLIR/LLVM API call sites to their non-deprecated forms.
Changes:
- Replace several
rewriter.create<...>uses withOp::create(...)helpers in Rock narrow-type emulation and rocMLIR custom TOSA decompose. - Update
llvm::StringSwitchusage to the non-deprecatedCases({ ... }, value)overload for gfx10 minor parsing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mlir/lib/Dialect/Rock/Transforms/EmulateNarrowType.cpp | Switch constant and reinterpret_cast construction to Op::create helpers. |
| mlir/lib/Dialect/Rock/IR/AmdArchDb.cpp | Use StringSwitch::Cases(std::initializer_list<...>) to avoid deprecated overload warnings. |
| mlir/lib/Conversion/RocmlirCustomTosaDecompose/RocmlirCustomTosaDecompose.cpp | Construct tensor.empty and tensor.insert_slice via Op::create helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
umangyadav
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is just a small PR to clean up build warnings that happen when building rocMLIR.
Technical Details
rewriter.create<tensor::EmptyOp>->tensor::EmptyOp::create.Cases("a", "b", val)→.Cases({"a", "b"}, val)rewriter.createcalls withop::createTest Plan
Test Result
Submission Checklist