feat(umbp): tunable read leases and tighter master lease default#452
Open
isytwu wants to merge 1 commit into
Open
feat(umbp): tunable read leases and tighter master lease default#452isytwu wants to merge 1 commit into
isytwu wants to merge 1 commit into
Conversation
- Add UMBP_DRAM_READ_LEASE_MS (default 500) to expose the peer DRAM/HBM read lease that was previously hardcoded at 500ms. - Add UMBP_SSD_READ_LEASE_MS (default 3000) and plumb the peer SSD staging-slot lease through as std::chrono::milliseconds; drop the unused PoolClientConfig::ssd_lease_timeout_s field. Was hardcoded 10s. - Lower UMBP_LEASE_DURATION_SEC default 10s -> 2s: the master read lease only needs to cover the master->reader RPC + reaching the peer, so 10s over-pinned actively-read keys against eviction. - UMBP_AUTO_FLUSH_EVENT_THRESHOLD=0 now disables size-based auto-flush instead of falling back to the default. - Remove legacy UMBP_ALLOCATION_TTL_SEC / UMBP_FINALIZED_RECORD_TTL_SEC (unused on the live path) from config, master startup log, and docs. - Update runtime-env-vars.md and design-master-control-plane.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UMBP_DRAM_READ_LEASE_MS(default 500) — peer DRAM/HBM read lease.UMBP_SSD_READ_LEASE_MS(default 3000) — peer SSD staging-slot lease; plumbed through asstd::chrono::milliseconds, dropping the unusedPoolClientConfig::ssd_lease_timeout_s(was hardcoded 10s).UMBP_LEASE_DURATION_SECdefault10s -> 2s: the master read lease only needs to cover the master→reader RPC + reaching the peer, so 10s over-pinned actively-read (hot) keys against eviction.UMBP_AUTO_FLUSH_EVENT_THRESHOLD=0now disables size-based auto-flush instead of falling back to the default.UMBP_ALLOCATION_TTL_SEC/UMBP_FINALIZED_RECORD_TTL_SEC(unused on the live path) from config, master startup log, and docs.runtime-env-vars.mdanddesign-master-control-plane.md.Test plan
ninja).test_umbp_env_time,test_ssd_read_lease_gating,test_peer_dram_allocator,test_umbp_master_client_flush_heartbeat,test_umbp_peer_service,test_peer_ssd_read_rpc.correctness128/128 hits, 0 mismatch;batch_perf~0.216 ms/get @ batch=1, all with the new lease envs set — confirms the tightened master lease and new peer lease knobs don't break the read path.