[OpenMP] Remove standalone build mode (amd-staging version)#1223
Conversation
|
Need to test this along with ROCm/aomp#1602 |
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
Remove all the CMake code for openmp standalone builds. Standalone builds have been superseded by runtimes default build. The runtimes default build can be thought of a standalone build with the standalone boilerplate contained in /runtimes/CMakeLists.txt. There is no need for each runtime to contain the same boilerplate code again. Co-authored-by: Michael Kruse <llvm-project@meinersbur.de>
estewart08
force-pushed
the
amd/dev/estewart/remove-openmp-standalone-logic-kruse
branch
from
b530b89 to
a7958d6
Compare
|
Combo psdb passed, this will need a manual override for approval. |
ronlieb
deleted the
amd/dev/estewart/remove-openmp-standalone-logic-kruse
branch
3 participants
Remove all the CMake code for openmp standalone builds. Standalone builds have been superseded by runtimes default build. The runtimes default build can be thought of a standalone build with the standalone boilerplate contained in /runtimes/CMakeLists.txt. There is no need for each runtime to contain the same boilerplate code again.